[wp-trac] [WordPress Trac] #36615: Avoid PHP notices when trying to update translations which are already up to date

[WordPress Trac]

#36615: Avoid PHP notices when trying to update translations which are already up
to date
-----------------------------+-------------------------
 Reporter:  ocean90          |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  4.6
Component:  Upgrade/Install  |    Version:
 Severity:  normal           |   Keywords:  needs-patch
  Focuses:                   |
-----------------------------+-------------------------
 This is bit of a race condition:

 * Make sure that you have outdated translations and auto-updates for
 translations are working.
 * Go to wp-admin/update-core.php.
 * Now do something else.
 * In the meantime WP has updated the translations in the background.
 * Click the Update Translations button.

 Expected: No PHP notices
 Actual: PHP notices:

 {{{
 NOTICE: wp-admin/includes/class-wp-upgrader.php:2204 - Trying to get
 property of non-object
 Language_Pack_Upgrader->bulk_upgrade, Language_Pack_Upgrader_Skin->before,
 Language_Pack_Upgrader->get_name_for_update
 NOTICE: wp-admin/includes/class-wp-upgrader-skins.php:811 - Trying to get
 property of non-object
 Language_Pack_Upgrader->bulk_upgrade, Language_Pack_Upgrader_Skin->before
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36615>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform