[wp-trac] [WordPress Trac] #36457: Customizer Device Preview: Use px units for tablet preview size

[WordPress Trac]

#36457: Customizer Device Preview: Use px units for tablet preview size
-----------------------------------------------------+---------------------
 Reporter:  celloexpressions                         |       Owner:  jorbin
     Type:  defect (bug)                             |      Status:  closed
 Priority:  normal                                   |   Milestone:  4.5.1
Component:  Customize                                |     Version:  4.5
 Severity:  normal                                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing has-screenshots  |     Focuses:  ui
-----------------------------------------------------+---------------------
Changes (by jorbin):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"37247"]:
 {{{
 #!CommitTicketReference repository="" revision="37247"
 Use `px` instead of `in` in device preview

 Devices are not consistent in how they handle `in` units. `in` was an
 attempt to cleverly disguise the exact size of the 'tablet'. The PHP code
 standards mentions avoiding clever code (
 https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/php/#clever-code ) but we should extend that idea to the css
 code as well.

 Props celloexpressions
 Fixes #36457
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36457#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform