[wp-trac] [WordPress Trac] #36589: Don't use localhost in Tests_Image_Header tests

[WordPress Trac]

#36589: Don't use localhost in Tests_Image_Header tests
--------------------------+------------------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------------
Description changed by ocean90:

Old description:

> `Tests_Image_Header::test_create_attachment_object()` and
> `Tests_Image_Header::test_insert_cropped_attachment()` are passing
> `http://localhost/foo-cropped.png` to
> `Custom_Image_Header::create_attachment_object()`. This method is using
> `getimagesize()` for the URL. I'm not sure if this a config issue but it
> seems like the timeout is pretty high so the tests are taking a minute to
> complete.
>
> Output by SpeedTrapListener:
>
> {{{
>  1. 60031ms to run Tests_WP_Site_Icon:test_create_attachment_object
>  2. 60030ms to run Tests_WP_Site_Icon:test_insert_cropped_attachment
> }}}

New description:

 `Tests_Image_Header::test_create_attachment_object()` and
 `Tests_Image_Header::test_insert_cropped_attachment()` are passing
 `http://localhost/foo-cropped.png` to
 `Custom_Image_Header::create_attachment_object()`. This method is using
 `getimagesize()` for the URL. I'm not sure if this a config issue but it
 seems like the timeout is pretty high so the tests are taking a minute to
 complete.

 Output of PHPunit:

 {{{
 1) Tests_Image_Header::test_create_attachment_object
 ImagickException: getimagesize(http://localhost/foo-cropped.png): failed
 to open stream: Connection refused

 src/wp-admin/custom-header.php:1160
 tests/phpunit/tests/image/header.php:116

 2) Tests_Image_Header::test_insert_cropped_attachment
 ImagickException: getimagesize(http://localhost/foo-cropped.png): failed
 to open stream: Connection refused

 src/wp-admin/custom-header.php:1160
 tests/phpunit/tests/image/header.php:132
 }}}

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36589#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform