[wp-trac] [WordPress Trac] #15800: Adding tabs to the "Edit Site"-pages in Network Admin

WordPress Trac noreply at wordpress.org
Mon Apr 18 20:19:47 UTC 2016


#15800: Adding tabs to the "Edit Site"-pages in Network Admin
-------------------------+-------------------------------------------------
 Reporter:               |       Owner:
  PuffyThePirateBoy      |      Status:  new
     Type:  enhancement  |   Milestone:  4.6
 Priority:  normal       |     Version:  3.1
Component:  Networks     |  Resolution:
  and Sites              |     Focuses:  accessibility, administration,
 Severity:  minor        |  multisite
 Keywords:  has-patch    |
  needs-testing          |
-------------------------+-------------------------------------------------

Comment (by johnjamesjacoby):

 Responding to @jeremyfelt's points:

 * I'm fine doing that elsewhere, but we'll need to be doubly sure we don't
 make any mistakes during the fork and merge of these two initiatives
 * The way we've been doing this everywhere else is to make these screens
 objects, but we can't easily have more than 1 'WP_Screen` object hanging
 around at any one time. I think because these tabs are put out at run time
 vs. precompiled on `init` or elsewhere, doing this late is the only place
 we currently have without inventing a new place
 * It looks fine until you start to have no tabs, which indicates something
 has gone horribly wrong. We should account for this, but it would require
 manually unsetting something in a forceful way, which makes me inclined to
 think someone doing that wants that level of control.
 * I know we don't do this in very many places anymore, but considering
 this is duplicated logic across 4 (or more) files, it felt right to put it
 inside the function. Once it was in there, I could imagine core wanting to
 modify this in the future, and/or plugins wanting to go even further into
 modifying the tabbed interface into something else. Naturally, I'm doing
 this, so I find it pretty useful as it is.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15800#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list