[wp-trac] [WordPress Trac] #31487: Semantic elements for non-link links: /wp-admin/customize.php

WordPress Trac noreply at wordpress.org
Sun Apr 17 15:33:55 UTC 2016


#31487: Semantic elements for non-link links: /wp-admin/customize.php
--------------------------+--------------------------------------------
 Reporter:  Cheffheid     |       Owner:  afercia
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.6
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, accessibility, javascript
--------------------------+--------------------------------------------
Changes (by afercia):

 * keywords:  has-patch needs-refresh => has-patch
 * owner:   => afercia
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.6


Comment:

 Replying to [comment:7 celloexpressions]:
 > Well, the list of issues on the ticket also covers some things that show
 up in the customizer, but come from more specific panels/sections.

 Yep, the original ticket Description is maybe a bit too broad, but then
 the actual patch focused just on the file `customize.php`.

 Many things have changed here, for example the `control-panel-back`
 control was removed in [33599] and the accordions are now sliding panels
 see [32649]. The refreshed patch:

 - makes the mobile preview/customize toggle a button
 - changes the "Close" link text from 'Cancel' to 'Close the Customizer and
 go back to the previous page', since this is a link, users need to have a
 clue about the link destination
 - adds a missing `type="button"`
 - removes unnecessary `keydown` events and `preventDefault()`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31487#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list