[wp-trac] [WordPress Trac] #34941: Make the main bootstrap process in ms-settings.php testable

[WordPress Trac]

#34941: Make the main bootstrap process in ms-settings.php testable
-------------------------------------------------+-------------------------
 Reporter:  jeremyfelt                           |       Owner:  jeremyfelt
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.6
Component:  Bootstrap/Load                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  multisite
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by jeremyfelt):

 * owner:   => jeremyfelt
 * status:  new => accepted


Comment:

 [attachment:34941.3.diff] adjusts a few things:

 * New function in `ms-load.php` is `ms_load_current_site_and_network()`.
 * Try to use discouraging language for use of this outside of core, also
 mark as `@private`.
 * Add a `$subdomain` parameter so that we can test both subdomain and
 subdirectory configs with relative ease.
 * Add bootstrap tests to account for subdirectory path segments of 2 vs
 the default of 1. This is marked as a todo in the current tests.
 * Add bootstrap tests for subdomain configuration. :tada:

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34941#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform