[wp-trac] [WordPress Trac] #30299: Inconsistent custom-background Body Class Behavior

WordPress Trac noreply at wordpress.org
Sat Apr 16 19:11:49 UTC 2016


#30299: Inconsistent custom-background Body Class Behavior
-------------------------------+------------------------------
 Reporter:  philiparthurmoore  |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Customize          |     Version:
 Severity:  normal             |  Resolution:
 Keywords:  2nd-opinion        |     Focuses:
-------------------------------+------------------------------
Changes (by celloexpressions):

 * keywords:   => 2nd-opinion


Comment:

 Realistically, I see this as an example of why we probably shouldn't have
 classes like `custom-background`, since they don't easily align with the
 way that it works and also don't necessarily provide much benefit. Unless
 we want to clear the theme mod when it's set back to the default (which
 could maybe be done), but I'm not sure if there are advantages there (and
 also keep in mind the `postMessage` support in the customizer, which is
 probably why it sets the option to the default value). Any calls to
 `get_theme_mod( 'background-color' )` should have the default hex color as
 a second argument to cover the default case. Should other CSS be changing
 when there's a custom background color?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30299#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list