[wp-trac] [WordPress Trac] #35457: Theme installer upload button improvements

[WordPress Trac]

#35457: Theme installer upload button improvements
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.6
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots                        |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  needs-patch => has-patch has-screenshots
 * milestone:  Future Release => 4.6


Comment:

 First pass:
 - restores the `themes.router.navigate()` stuff to support the `upload`
 route that was removed in [37221]
 - makes the button a button
 - adds a notice displayed when JavaScript is off (as done in the Media
 screen), see screenshot below
 - adds some `hide-if-no-js` CSS classes

 Also, I'd propose to don't hide the themes when the uploader is open, for
 consistency with the Plugins screen and maybe because it is not needed?

 About the themes.router.navigate()` I'm not sure it is really useful and
 actually used, I'd propose to consider to remove it completely. /cc
 @ocean90 @obenland


 In the screenshot below, the theme installer screen with JS off, compared
 to the Media grid with JS off and the proposed new notice:

 [[Image(https://cldup.com/TbJ_kIplyH.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35457#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform