[wp-trac] [WordPress Trac] #36526: Not needed postmeta saved when restoring post revision

[WordPress Trac]

#36526: Not needed postmeta saved when restoring post revision
--------------------------+------------------------------
 Reporter:  pavelevap     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Revisions     |     Version:  3.6.1
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:   => needs-patch


Comment:

 Plugin directory search for `_post_restored_from` returned only two
 results:
 {{{
 simple-history/loggers/SimplePostLogger.php

         // Array with custom field keys to ignore because changed
 everytime or very internal
         $arr_meta_keys_to_ignore = array(
                 "_edit_lock",
                 "_edit_last",
                 "_post_restored_from",
                 "_wp_page_template"
         );

 wr-pagebuilder/core/converter/converter.php

         $post_meta = $wpdb->get_results( "SELECT * FROM
 {$table_prefix}postmeta WHERE post_id = {$this->post->ID};" );
         $ignore    = array( '_edit_last', '_edit_lock',
 '_post_restored_from' );

         foreach ( $post_meta as $meta ) {
                 if ( ! in_array( $meta->meta_key, $ignore ) ) {
                         $wpdb->query( "INSERT INTO {$table_prefix}postmeta
 (post_id, meta_key, meta_value) VALUES ({$id}, '{$meta->meta_key}',
 '{$meta->meta_value}');" );
                 }
         }
 }}}
 I think we should be able to remove it in a DB upgrade routine for 4.6.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36526#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform