[wp-trac] [WordPress Trac] #36528: Only run imagemin task inside precommit task if images are added/modified

[WordPress Trac]

#36528: Only run imagemin task inside precommit task if images are added/modified
------------------------------+------------------
 Reporter:  iseulde           |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.6
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+------------------

Comment (by netweb):

 Replying to [comment:4 iseulde]:
 > You'll have exactly the same issue with e.g. the `postcss` task for CSS
 files.

 Indeed, the same issue will happen with PostCSS, and this could be more
 problematic than the imagemin case as they have more frequent release.

 Replying to [comment:4 iseulde]:
 > I don't think the `precommit` task should look at that as you want to
 make sure ''your'' changes are ready for commit or to be uploaded as a
 patch, and not have all images modified because the module changed. This
 should be a separate commit and is likely to be the task of someone else,
 it needs its own ticket etc. At some point someone will run `prerelease`
 which will make sure the changes are detected. We could even make sure all
 tasks with `precommit` are run if there are no file modifications.
 I disagree with this, after each commit `grunt build` is ran and these
 changes are reflected in `build.svn.wordpress.org` and many people run
 `/trunk` live on their sites, the primary repo `develop.svn.wordpress.org`
 should be in the most "pristine" condition it can be at all times to
 reflect the most recent changes for those who run `/trunk`.

 This should *not* be "someone elses" task ran at "some point", this task
 should be and I believe is one of the responsibilities of a core
 committers role.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36528#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform