[wp-trac] [WordPress Trac] #36510: Twenty eleven page templates with widgets incorrectly styled
WordPress Trac
noreply at wordpress.org
Thu Apr 14 22:54:48 UTC 2016
#36510: Twenty eleven page templates with widgets incorrectly styled
-------------------------------------------------+--------------------
Reporter: Clorith | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.5.1
Component: Bundled Theme | Version: 4.5
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion needs-testing | Focuses: ui
-------------------------------------------------+--------------------
Comment (by scottkr24):
I took my functions.php file and commented out this
function twentyeleven_body_classes( $classes ) {
if ( function_exists( 'is_multi_author' ) && ! is_multi_author() )
$classes[] = 'single-author';
if ( is_singular() && ! is_home() && ! is_page_template(
'showcase.php' ) && ! is_page_template( 'sidebar-page.php' ) )
$classes[] = 'singular';
return $classes;
}
add_filter( 'body_class', 'twentyeleven_body_classes' );
Then dropped in what you posted. Went to look at the site, it was blank,
nothing was there.
Replying to [comment:16 davidakennedy]:
> Thanks everyone for reporting this, and digging into it. Thanks
@eceleste for the nice investigative work!
>
> I've added two patches with different approaches. There may be better
ways to tackle this, but I wanted to throw a few possibilities out there.
The challenge here is that we don't want to assume someone has 4.4 or
above installed. This should work all the way back to the version of
WordPress that Twenty Eleven launched with.
>
> The first patch is probably better, since it has everything in one
place. The second one only runs on WordPress 4.4 and above, when the
`singular` class change was merged in. I've tested both on WordPress 4.5
and WordPress 4.3.
>
> Feedback welcome! I can also add another patch here to update the
version number, changelog, etc. when we decide on an approach. I'd like to
see this fixed as soon as possible.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36510#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list