[wp-trac] [WordPress Trac] #21870: @ error control operator hides fatal error on mysql_fetch_object

[WordPress Trac]

#21870: @ error control operator hides fatal error on mysql_fetch_object
------------------------------+------------------------
 Reporter:  ericlewis         |       Owner:  ericlewis
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.5
Component:  Database          |     Version:  1.5
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------------

Comment (by Otto42):

 Just a note, in WordPress 4.5, this fix is now causing issues where hosts
 with PHP 5.5 and WP 4.5 are attempting to connect with mysqli, and the
 mysql_old_password error is not being ignored properly and output to the
 page.

 https://wordpress.org/support/topic/authentication-failure-on-upgrading-
 to-wp45?replies=3

 Because of the early output, cookies cannot be set, rendering users unable
 to log into wp-admin for their sites.

 The fallback to the mysql client still appears to work okay on these sites
 (sometimes), however errors from mysqli_real_connect should be caught and
 handled somewhat better, I think. The real fix, of course, is for the
 database servers not to be configured to use the old_password hash
 mechanism, but still, that's a valid warning message to attempt to
 suppress.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21870#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform