[wp-trac] [WordPress Trac] #13949: Add a sprintf style argument to wp_list_categories() for title tag.
WordPress Trac
noreply at wordpress.org
Wed Apr 13 15:15:48 UTC 2016
#13949: Add a sprintf style argument to wp_list_categories() for title tag.
-------------------------------------------------+-------------------------
Reporter: mfields | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future
Component: Taxonomy | Release
Severity: normal | Version:
Keywords: needs-testing needs-patch needs- | Resolution:
unit-tests | Focuses:
-------------------------------------------------+-------------------------
Changes (by boonebgorges):
* keywords: has-patch needs-testing => needs-testing needs-patch needs-
unit-tests
Comment:
Hi @Mte90 - Thanks for the patch. A few comments and requests:
* We'll need documentation for the new parameter. See
https://make.wordpress.org/core/handbook/best-practices/inline-
documentation-standards/php/
* Why are we calling it `feed_title` when it's used for the `alt`
attribute? Is there an example of this usage elsewhere in WP?
* You mentioned that `title_li` does the same thing as the proposed
`title_format`, but I don't think that's true. [attachment:13949.diff]
proposes a `sprintf`-friendly string that is used for the link `title`
attribute. I don't have strong feelings about whether this feature is
necessary.
* Ideally, we'd have unit tests demonstrating the `sprintf()` behavior.
See `tests/phpunit/tests/category/wpListCategories.php`
--
Ticket URL: <https://core.trac.wordpress.org/ticket/13949#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list