[wp-trac] [WordPress Trac] #36485: Lost pending customizer settings after theme change

[WordPress Trac]

#36485: Lost pending customizer settings after theme change
--------------------------+------------------------------
 Reporter:  mikeschroder  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Customize     |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  javascript
--------------------------+------------------------------

Comment (by celloexpressions):

 The theme switcher uses the `customize-loader` script, which gives the
 illusion that there is no page load. However, what really happens is we
 fade in a full-screen loading indicator while waiting for a response from
 the serve to navigate to the new URL. However, when there are dirty
 settings, it has to `confirm()` (?) first. There isn't (or wasn't, at
 least) to know when a true/false value is returned from the confirm call,
 so we have to hide the loading indicator as soon as the confirm window is
 closed so that the user isn't stuck with a loading indicator preventing
 them from getting "back" to the customizer so that they can save there
 changes. When you do chose to lose changes, it still hides the loader,
 giving the impression of it hanging when really it's just doing the same
 thing it does when there are no dirty settings, but without the loading
 indicator.

 Not a great UX, so hopefully we'll be able to improve on it at some point.

 (to clarify, "stay on this page" is the previous theme, where settings are
 dirty; "leave" is go to the new theme, since you don't actually trigger
 the link until it's the last )

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36485#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform