[wp-trac] [WordPress Trac] #36392: wp_add_inline_script() breaks script dependency order when using script loader (no SCRIPT_DEBUG)

WordPress Trac noreply at wordpress.org
Sat Apr 9 13:22:10 UTC 2016


#36392: wp_add_inline_script() breaks script dependency order when using script
loader (no SCRIPT_DEBUG)
--------------------------------------+-------------------------
 Reporter:  westonruter               |       Owner:  swissspidy
     Type:  defect (bug)              |      Status:  assigned
 Priority:  high                      |   Milestone:  4.5
Component:  Script Loader             |     Version:  trunk
 Severity:  major                     |  Resolution:
 Keywords:  has-unit-tests has-patch  |     Focuses:
--------------------------------------+-------------------------

Comment (by ocean90):

 @jeremyfelt Nice catch, thanks. Thought we had a test for this so I
 haven't checked that explicit.

 Since nobody seems to be in favor of reverting the feature (What a
 surprise. ;)) [attachment:36392.diff] looks like the only way to keep
 `wp_add_inline_script()` without a major refactoring to support adding
 scripts to core dependencies.

 [attachment:36392.2.diff] is the same as [attachment:36392.diff] but with
 more descriptive method names and two more scripts for the last test.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36392#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list