[wp-trac] [WordPress Trac] #36452: customize_value should be passed $this

[WordPress Trac]

#36452: customize_value should be passed $this
---------------------------+-----------------------------
 Reporter:  nwp_developer  |       Owner:
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  Future Release
Component:  Customize      |     Version:  4.4.2
 Severity:  normal         |  Resolution:  duplicate
 Keywords:  has-patch      |     Focuses:
---------------------------+-----------------------------
Changes (by celloexpressions):

 * keywords:   => has-patch
 * type:  feature request => defect (bug)
 * milestone:   => Future Release


Comment:

 Good catch @nwp_developer!

 I think this was an oversight when we started passing `$this` with all of
 the hooks here (hence marking as a bug). Every action and filter in
 `WP_Customize_Setting` passes `$this` as its last argument with this
 change; see [attachment:36452.diff]. We do need to keep `$value` as the
 first argument for backwards compatibility, so a second parameter with the
 setting would be passed as well now. See previously #27979.

 Per Slack discussion, let's see if we can get this smaller change in
 without waiting for a full resolution of the proposed new hooks in #29316.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36452#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform