[wp-trac] [WordPress Trac] #36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small images.
WordPress Trac
noreply at wordpress.org
Fri Apr 8 00:31:45 UTC 2016
#36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small
images.
-------------------------------------------------+-------------------------
Reporter: mikeschroder | Owner: obenland
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Customize | Version: trunk
Severity: major | Resolution:
Keywords: has-patch dev-feedback needs- | Focuses: javascript
testing commit |
-------------------------------------------------+-------------------------
Comment (by jeremyfelt):
Spent some time with [attachment:36412.2.diff], and the changes look good.
In Twenty Sixteen, I tested:
* tall, wide, and square images
* flex-height, flex-width, and both enabled
* square, tall, wide ratios in defined width/height
All works as expected. I was able to get the crop tool to disappear
(https://cloudup.com/cWka3_cR-Y5), though I confirmed that is not a
regression from 4.4.2. Maybe a new ticket for adding a sane min-height
/min-width (as @azaozz mentioned earlier)? Even a small default of 5
instead of deleting the property prevents the issue.
In general, +1 for commit unless we want to solve the min height/width
issue at the same time.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36412#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list