[wp-trac] [WordPress Trac] #36392: wp_add_inline_script() breaks script dependency order when using script loader (no SCRIPT_DEBUG)

WordPress Trac noreply at wordpress.org
Thu Apr 7 14:56:12 UTC 2016


#36392: wp_add_inline_script() breaks script dependency order when using script
loader (no SCRIPT_DEBUG)
----------------------------------------+-------------------------
 Reporter:  westonruter                 |       Owner:  swissspidy
     Type:  defect (bug)                |      Status:  assigned
 Priority:  high                        |   Milestone:  4.5
Component:  Script Loader               |     Version:  trunk
 Severity:  major                       |  Resolution:
 Keywords:  has-unit-tests needs-patch  |     Focuses:
----------------------------------------+-------------------------

Comment (by gitlost):

 Looking through the diffs in #14853, it seems that not concatenating when
 have inline code (before and/or after) was an artifact of the out-of-
 bandness of `$print_html`, rather than wanted behaviour, so I've uploaded
 a version of the "batch" demo which only bumps the batch when there's
 conditional data or it's not in the default directories (and thus can't be
 concatenated).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36392#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list