[wp-trac] [WordPress Trac] #36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small images.

[WordPress Trac]

#36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small
images.
-------------------------------------------------+-------------------------
 Reporter:  mikeschroder                         |       Owner:  obenland
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  major                                |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:  javascript
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 OK, I agree it is too late at this stage to fix the bigger things like
 forcing the user to crop an image when cropping is not necessary (when
 flex_width or flex_height is set, we can scale the whole image, no need of
 cropping), or the themes always having to set width and height even when
 they are then overridden with flex_width and/or flex height (code cannot
 handle not having width or height).

 I'm a bit concerned that 36412.2.diff changes the default method, i.e. the
 changes affect all three places the cropper is used. One thing that's
 affected is that when setting a site icon and using medium image size
 (300x400px), the crop rectangle now gets "locked" and cannot be scaned
 down. When using a large image (3000x4000px) the crop rectangle can be
 scaled down to 95px (screen resolution).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36412#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform