[wp-trac] [WordPress Trac] #36419: Request data is inconsistently slashed in REST API callbacks

[WordPress Trac]

#36419: Request data is inconsistently slashed in REST API callbacks
-------------------------------------------------+-------------------------
 Reporter:  joehoyle                             |       Owner:
     Type:  defect (bug)                         |  markjaquith
 Priority:  highest omg bbq                      |      Status:  reviewing
Component:  REST API                             |   Milestone:  4.5
 Severity:  blocker                              |     Version:  4.4
 Keywords:  has-patch has-unit-tests dev-        |  Resolution:
  feedback                                       |     Focuses:
-------------------------------------------------+-------------------------

Comment (by dd32):

 > but I'm so wildly unexcited about putting in a breaking change like this
 during RC.

 I'm not wild about it either, but figure we're going to have to fix it
 sooner or later, and I'd rather just rip the bandaid off sooner than
 later.

 The inconsistency comes in that the slashing the application gets depends
 100% on where the data came from - JSON blob POST'd or POST params - and
 the endpoint doesn't know which it is (I mean, there's hacky ways to
 detect it I'm sure). The client decides if the application gets unslashed
 data (JSON blob) or slashed data (POST params).

 I feel that just fixing it to be unslashed is a legit bugfix that will fix
 more than it'll do harm.
 Leaving it for a soak will mean that we'll maintain the current
 inconsistent and buggy approach until 4.6 is released (and 4.4.x/4.5.x
 won't get fixed).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36419#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform