[wp-trac] [WordPress Trac] #33699: Hidden password input fields should default to disabled="disabled"

WordPress Trac noreply at wordpress.org
Wed Sep 30 17:23:08 UTC 2015


#33699: Hidden password input fields should default to disabled="disabled"
-----------------------------+---------------------------------------------
 Reporter:  raamdev          |       Owner:  adamsilverstein
     Type:  defect (bug)     |      Status:  assigned
 Priority:  normal           |   Milestone:  4.4
Component:  Users            |     Version:  4.3
 Severity:  normal           |  Resolution:
 Keywords:  has-patch dev-   |     Focuses:  ui, javascript, administration
  feedback                   |
-----------------------------+---------------------------------------------
Changes (by adamsilverstein):

 * keywords:  needs-patch => has-patch dev-feedback
 * milestone:  Future Release => 4.4


Comment:

 In [attachment:33699.diff]:
 * Disable all hidden input fields on initial load, when the 'Generate
 Password' button is visible and the fields are hidden.
 * Enable all inputs when 'Generate Password' button clicked.
 * Disable all inputs when 'Cancel' clicked.

 Prevents an issue where password helpers would autofill the hidden
 password fields, inadvertently causing password changes when editing other
 fields on the profile page among other issues. This patch keeps the fields
 'disabled' when they are hidden which should prevent submission even if
 they are filled.

 @JasWSInc: Can you please check the patch to see if this resolves the
 issue you see?

 Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33699#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list