[wp-trac] [WordPress Trac] #8071: Refrain from querying all the comments on a post when paged
WordPress Trac
noreply at wordpress.org
Wed Sep 30 03:06:24 UTC 2015
#8071: Refrain from querying all the comments on a post when paged
--------------------------------------+---------------------------
Reporter: markjaquith | Owner: boonebgorges
Type: enhancement | Status: closed
Priority: normal | Milestone: 4.4
Component: Comments | Version: 2.7
Severity: normal | Resolution: fixed
Keywords: dev-feedback needs-patch | Focuses:
--------------------------------------+---------------------------
Comment (by boonebgorges):
In [changeset:"34713"]:
{{{
#!CommitTicketReference repository="" revision="34713"
Fix logical errors in some comment pagination tests.
The tests included in [34669] contained a couple of problems:
* Comments were not always created in the expected order, due to the
incorrect use of 'comment_date_gmt'.
* 'asc'/'desc' and 'older'/'newer' were confused.
* 'default_comments_page=newest' ('last') didn't properly account for the
cpage=1 offset.
The code itself powering this pagination was correct; it's only the tests
that
were wrong.
See #8071.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/8071#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list