[wp-trac] [WordPress Trac] #33887: Multisite update from SSL network fails on non SSL domains

[WordPress Trac]

#33887: Multisite update from SSL network fails on non SSL domains
----------------------------------+----------------------------------------
 Reporter:  typify                |       Owner:
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  Awaiting Review
Component:  Upgrade/Install       |     Version:  4.3
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-      |     Focuses:  administration, multisite
  testing                         |
----------------------------------+----------------------------------------
Changes (by akibjorklund):

 * keywords:   => has-patch needs-testing


Comment:

 We have this issue on one site as well.

 The problem is that set_url_scheme(), which is called by get_site_url() –
 twice, once for displaying the root URL and second time for getting the
 actual connect URL – forces the protocol to be SSL if upgrade.php is
 called with SSL.

 My initial solution would be to add a scheme 'original'. That would be a
 special case and would not alter the protocol in any way.

 I've attached a patch for this approach.

 Related: We happen to use the plugin WordPress MU Domain Mapping on the
 site and that also filters the admin_url to force https when is_ssl()
 returns true. By disabling the plugin temporarily and using my patch, I
 was able to upgrade the database.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33887#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform