[wp-trac] [WordPress Trac] #34074: wp_debug false still showing errors

[WordPress Trac]

#34074: wp_debug false still showing errors
--------------------------+-----------------------------
 Reporter:  siebje        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  4.3.1
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Where:


 {{{
 define('WP_DEBUG', false);
 }}}

 before PHP 5.4 did not show any errors, now after updating to PHP higher
 then 5.4, it does show errors:

 [[Image(http://wsinternetservices.nl/temp/errors.jpg)]]

 Now we have to add extra line of code to hide errors:

 {{{
 define('WP_DEBUG', false);
 @ini_set('display_errors', 0);
 }}}

 Why is this ini_set part not included in the core wp_debug_mode function?

 Because the above code now basicly is the same as:

 {{{
 define('WP_DEBUG', true);
 define('WP_DEBUG_DISPLAY', false);
 }}}

 Because in the WP_DEBUG_DISPLAY the ini_set IS included in the core
 wp_debug_mode function:

 {{{
 if ( WP_DEBUG_DISPLAY )
 ini_set( 'display_errors', 1 );
 elseif ( null !== WP_DEBUG_DISPLAY )
 ini_set( 'display_errors', 0 );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34074>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform