[wp-trac] [WordPress Trac] #34068: Comment permalink always include comment page

[WordPress Trac]

#34068: Comment permalink always include comment page
------------------------------------------+--------------------
 Reporter:  knutsp                        |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  4.4
Component:  Comments                      |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:   => needs-patch needs-unit-tests
 * milestone:  Awaiting Review => 4.4


Comment:

 This is due to the fact that pagination is always forced, so
 'page_comments' no longer does anything.

 In fact, prior to [34561], 'comment-page-1' *did* appear on all comment
 first pages, when 'page_comments' was enabled.

 It seems to me that 'comment-page-1' should be banished. Page 1 of
 comments should always have the same URL as the post itself. This change
 will require a battery of unit tests to account for the various scenarios
 (specifically, the various values of 'default_comments_page').
 `get_comment_link()` appears to be the correct place for this change.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34068#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform