[wp-trac] [WordPress Trac] #34045: "Add New" button links to wrong location

[WordPress Trac]

#34045: "Add New" button links to wrong location
-----------------------------+-----------------------------
 Reporter:  johnjamesjacoby  |       Owner:  norcross
     Type:  defect (bug)     |      Status:  assigned
 Priority:  normal           |   Milestone:  4.4
Component:  Administration   |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  administration
-----------------------------+-----------------------------

Comment (by helen):

 There was no "Add New" link there previously, and there shouldn't be one
 there, so the goal now is to remove it again.

 [attachment:30405-02.diff] is the most immediately obvious way to do it -
 `$post_new_file` gets redefined in other files, so unsetting it in this
 case is a way to accomplish this, and possibly is the right thing to do.
 However, looking at [attachment:34041.01.patch] does make me wonder if
 maybe we shouldn't be reusing a global variable like this and if it was
 intentional or not. @wonderboymusic - was there a reason you reused that
 variable name in [33723]?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34045#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform