[wp-trac] [WordPress Trac] #34043: wp_check_for_changed_slugs() ignores attachments

[WordPress Trac]

#34043: wp_check_for_changed_slugs() ignores attachments
-------------------------------------+------------------
 Reporter:  swissspidy               |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.4
Component:  Posts, Post Types        |     Version:  2.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+------------------
Changes (by pento):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 * Given that there are other post types that can use the post_status
 `inherit`, I think the `in_array($post->post_status, array( 'publish',
 'inherit' ) )` check needs to be stricter, and only allow attachments with
 that post_status.
 * While you're editing the next line, s/hasnt/hasn't/ in the comment. :-)
 * A few spots missing a space inside the brackets.

 I'm also pondering if, when changing the slug on a post, the slug on
 attachments should change, too. I'm open to arguments either way.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34043#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform