[wp-trac] [WordPress Trac] #19159: When Inactive Widgets list gets long it is hard to clear
WordPress Trac
noreply at wordpress.org
Sat Sep 26 14:55:42 UTC 2015
#19159: When Inactive Widgets list gets long it is hard to clear
------------------------------------------------+-----------------------
Reporter: westi | Owner: cdog
Type: enhancement | Status: accepted
Priority: normal | Milestone: 4.4
Component: Widgets | Version: 3.3
Severity: normal | Resolution:
Keywords: ux-feedback dev-feedback has-patch | Focuses: ui
------------------------------------------------+-----------------------
Comment (by chriscct7):
Couple things so far.
Any thing that uses $_POST should be isset checked, so for example before
{{{
unset( $_POST['removeinactivewidgets'], $_POST['action'] );
}}}
the POST value should be checked to ensure it exists
Also because this is a new patch, it should follow the current WP code
guidelines, so
{{{
if ( ! current_user_can( 'edit_theme_options' ) )
wp_die( -1 );
}}}
should be
{{{
if ( ! current_user_can( 'edit_theme_options' ) ) {
wp_die( -1 );
}
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/19159#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list