[wp-trac] [WordPress Trac] #29719: Connection error to WordPress.org when HTTP calls disabled

[WordPress Trac]

#29719: Connection error to WordPress.org when HTTP calls disabled
-----------------------------+------------------------------
 Reporter:  grapplerulrich   |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  4.0
 Severity:  minor            |  Resolution:
 Keywords:  needs-patch      |     Focuses:  administration
-----------------------------+------------------------------

Comment (by grapplerulrich):

 @ocean90 - Thank you for explaining the history.

 The problem is that the following code makes the assumption that the error
 is an SSL error but there a number of different error messages in class-
 http.php. Theoretically we would need to check that it is a error specific
 to SSL and not an error like `return new WP_Error( 'http_request_failed',
 __( 'User has blocked requests through HTTP.' ) );`


 {{{
         if ( $ssl && is_wp_error( $response ) ) {
                 trigger_error( __( 'An unexpected error occurred.
 Something may be wrong with WordPress.org or this server’s
 configuration. If you continue to have problems, please try the <a
 href="https://wordpress.org/support/">support forums</a>.' ) . ' ' . __(
 '(WordPress could not establish a secure connection to WordPress.org.
 Please contact your server administrator.)' ), headers_sent() || WP_DEBUG
 ? E_USER_WARNING : E_USER_NOTICE );
                 $response = wp_remote_post( $http_url, $options );
         }
 }}}

 I am not sure how best to solve this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29719#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform