[wp-trac] [WordPress Trac] #29719: Connection error to WordPress.org when HTTP calls disabled

[WordPress Trac]

#29719: Connection error to WordPress.org when HTTP calls disabled
-------------------------------------------------+-------------------------
 Reporter:  grapplerulrich                       |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Upgrade/Install                      |  Review
 Severity:  minor                                |     Version:  4.0
 Keywords:  has-patch 2nd-opinion needs-testing  |  Resolution:
                                                 |     Focuses:
                                                 |  administration
-------------------------------------------------+-------------------------

Comment (by grapplerulrich):

 The error message that I was getting was "<b>Warning</b>:  An unexpected
 error occurred. Something may be wrong with WordPress.org or this server’s
 configuration. If you continue to have problems, please try the <a
 href="https://wordpress.org/support/">support forums</a>. (WordPress could
 not establish a secure connection to WordPress.org. Please contact your
 server administrator.) in <b>/wp-includes/update.php</b> on line
 <b>122</b><br>"

 I am mentioning it as I could not find the issue when I started looking at
 it again.

 The check `if ( $ssl && is_wp_error( $raw_response ) ) {` does not seem
 right as it is only activated when ssl is supported and there is an error.
 Another problem with current code is that only a standard SSL error is
 displayed when the error could be something else. With the current setup
 the error `return new WP_Error( 'http_request_failed', __( 'User has
 blocked requests through HTTP.' ) );` in wp-includes/class-http.php is
 never displayed.

 The new patch 29719.1.patch​ should fix it. I am not sure if we should be
 showing a PHP error when external http requests are disabled. Perhaps a
 notification would be better.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29719#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform