[wp-trac] [WordPress Trac] #33986: Checkbox for upload_space_check_disabled does not reflect actual behaviour

[WordPress Trac]

#33986: Checkbox for upload_space_check_disabled does not reflect actual behaviour
--------------------------------+-----------------------------
 Reporter:  stephenharris       |      Owner:
     Type:  defect (bug)        |     Status:  new
 Priority:  normal              |  Milestone:  Awaiting Review
Component:  Networks and Sites  |    Version:  4.3.1
 Severity:  normal              |   Keywords:
  Focuses:  ui, multisite       |
--------------------------------+-----------------------------
 If the value for `upload_space_check_disabled` in the database is a falsy
 value other than zero (e.g. an empty string or indeed if the key is not in
 the database) then, as expected, the limit is not disabled.

 However, in the admin settings page the checkbox remains unchecked. It
 ''should'' be checked because the limit is still in effect. However, the
 checkbox is checked only if the setting value is 0. (see
 https://github.com/WordPress/WordPress/blob/7a154ca66615255e5d4b6b44f6d1f4634f077bc0
 /wp-admin/network/settings.php#L27).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33986>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform