[wp-trac] [WordPress Trac] #33646: #a11y-headings - the Screen Options h5

[WordPress Trac]

#33646: #a11y-headings - the Screen Options h5
-------------------------------------+----------------------------
 Reporter:  afercia                  |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.4
Component:  Administration           |     Version:  4.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility
-------------------------------------+----------------------------

Comment (by afercia):

 Refreshed patch as per @westonruter suggestion. I'm not sure about a
 couple of things though. Before, the check for

 {{{
 isset( $wp_meta_boxes[ $this->id ] ) || $this->get_option( 'per_page' ) ||
 ( $columns && empty( $columns['_title'] ) )
 }}}

 was used just for printing out (or not printing out) the heading 'Show on
 screen'. Now, it's used to conditionally print out the main fieldset + its
 legend but:
 - we're checking for the "per page" option but then the per page field is
 outside the fieldset... maybe we should remove the check or move the per
 page field inside the fieldset
 - if I'm not mistaken, in a hypothetical screen with meta boxes + columns
 with no title, the second group of checkboxes would be printed out without
 a "title"

 Any thoughts?

 Side note: there are outstanding accessibility issues in this form but
 they should go in separate tickets.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33646#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform