[wp-trac] [WordPress Trac] #28290: Changing _site_option functions for _network_option functions

[WordPress Trac]

#28290: Changing _site_option functions for _network_option functions
------------------------------------+---------------------------
 Reporter:  jmlapam                 |       Owner:  spacedmonkey
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.4
Component:  Options, Meta APIs      |     Version:  4.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  multisite
------------------------------------+---------------------------

Comment (by DrewAPicture):

 Replying to [comment:24 spacedmonkey]:
 > Replying to [comment:23 DrewAPicture]:
 > > @spacedmonkey: On the duplicate hooks point, I like the idea of
 introducing the new hooks and deprecating the old ones. I'm reviving
 #10441 to tackle that angle.
 > I like the idea of having the ability to deprecate filters and actions.
 But from a code stand point, there is nothing for me to do? Wouldn't it be
 better to merge this and refractively give this code. I am sure they will
 be lots of places where hooks should be deprecated.

 For now, let's just skip adding new hooks altogether and relying on the
 old ones.

 > > I'd say go ahead and split the patches now as discussed.
 >
 > Confused by this. What do I need to do from a patch stand point? Isn't
 it better to merge this and then I will create another ticket / patch to
 change this over the function name.

 It would be helpful to handle it all here, just in separate patches. The
 main reason for separate patches is to keep the commits cleaner. The
 second reason is that in patches where we touch a lot of code, they often
 fall out of sync and have to be refreshed. It's a lot easier to commit the
 base functionality, then generate a patch for the replacements (if any)
 after that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28290#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform