[wp-trac] [WordPress Trac] #29792: Grunt: Add a precommit task to check for CSS syntax errors

[WordPress Trac]

#29792: Grunt: Add a precommit task to check for CSS syntax errors
------------------------------+-----------------------------
 Reporter:  helen             |       Owner:  netweb
     Type:  enhancement       |      Status:  assigned
 Priority:  normal            |   Milestone:  Future Release
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+-----------------------------
Changes (by netweb):

 * keywords:  has-patch =>


Comment:

 I’ll refresh the patch here in a day or two once the direction on a couple
 of bug fixes upstream are known.

 For the moment some quick stats compared my previous comments above where
 we had 4,000/5,000 warnings this is now down to ~200 warnings
 [https://core.trac.wordpress.org/attachment/ticket/29792/29792-warnings-
 without-vendor-prefix.txt 29792-warnings-without-vendor-prefix.txt] or
 1,000 warnings
 ([https://core.trac.wordpress.org/attachment/ticket/29792/29792-warnings-
 with-vendor-prefix.txt 29792-warnings-with-vendor-prefix.txt]) when
 including vendor prefixes (waiting on upstream bug fix for vendor
 prefixes).

 A preliminary CSS patch
 [https://core.trac.wordpress.org/attachment/ticket/29792/29792-css-
 patch.diff 29792-css-patch.diff] is also attached that shows what we’ll be
 looking to commit in core. I’m attaching this CSS file now for review, if
 there are changes in this that you don’t think should be there and we
 should have more rules to allow for that particular CSS formatting let me
 know and we can create more rules or iterate on the existing rules to
 allow these changes.

 Bonus Points: The above also now includes SCSS linting and fixes that will
 be part of #26905

 @Helen and @Nacin, if you'd be so kind to take a peek inside
 [https://core.trac.wordpress.org/attachment/ticket/29792/29792-css-
 patch.diff 29792-css-patch.diff] and let me know any pain points you can
 foresee I can then continue on iterating these rules :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29792#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform