[wp-trac] [WordPress Trac] #33923: Post Lists Table: 'All' view not selected for paged responses

[WordPress Trac]

#33923: Post Lists Table: 'All' view not selected for paged responses
-------------------------------+------------------------------
 Reporter:  kraftbj            |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Posts, Post Types  |     Version:  4.2
 Severity:  normal             |  Resolution:
 Keywords:  has-patch          |     Focuses:  administration
-------------------------------+------------------------------
Description changed by pento:

Old description:

> In [31828] ( see: #24869 ), a new `is_base_request` function is added to
> class-wp-posts-lists-table.php to indicate if the "All" view should have
> the current class associated with it, intentionally not including it when
> the view is filtered (by counting the `$_GET` array).
>
> This should still select "All" when paging through that view.
>
> Steps to reproduce:
> Visit the Posts list (Posts->All Posts) and page to a second page.
>
> Expected: "All" to still have the current class and reflect the
> applicable styling.
>
> Actual: No "current" defined.
>
> Least churn would be to unset $_GET['paged']. AFAIK, unset only impacts
> the local instance of a global, so we should be able to do that in one
> line without impacting anything else.

New description:

 In [31828] ( see: #24869 ), a new `is_base_request` function is added to
 class-wp-posts-lists-table.php to indicate if the "All" view should have
 the current class associated with it, intentionally not including it when
 the view is filtered (by counting the `$_GET` array).

 This should still select "All" when paging through that view.

 Steps to reproduce:
 Visit the Posts list (Posts->All Posts) and page to a second page.

 Expected: "All" to still have the current class and reflect the applicable
 styling.

 Actual: No "current" defined.

 Least churn would be to unset `$_GET['paged']`. AFAIK, unset only impacts
 the local instance of a global, so we should be able to do that in one
 line without impacting anything else.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33923#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform