[wp-trac] [WordPress Trac] #33926: Improve WordPress Compatibility with HHVM

[WordPress Trac]

#33926: Improve WordPress Compatibility with HHVM
--------------------------+-----------------------------
 Reporter:  wjywbs        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 When running the WordPress unit tests with HHVM, there are 2 failures and
 1 error.

 1. Do not use empty db handle to avoid catchable fatal error.
 2. Do not trim the cdata because CDATA in xml is parsed differently in
 hhvm and php. (Upstream bug report is at
 https://github.com/facebook/hhvm/issues/5844)

 Attached are the fixes for the 2 failures.

 The 1 error is:

 1) Tests_Auth::test_empty_user_activation_key_fails_key_check
 crypt(): No salt parameter was specified. You must use a randomly
 generated salt and a strong hash function to produce a secure hash.

 src/wp-includes/class-phpass.php:272
 src/wp-includes/user-functions.php:1879
 tests/phpunit/tests/auth.php:257

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33926>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform