[wp-trac] [WordPress Trac] #33741: Remove references to my-hacks.php and the hack_file option

[WordPress Trac]

#33741: Remove references to my-hacks.php and the hack_file option
--------------------------+-----------------------
 Reporter:  bobbingwide   |       Owner:  jorbin
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.4
Component:  Plugins       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------
Changes (by nacin):

 * keywords:  has-patch dev-feedback commit =>
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 If an option is going to be removed, it needs to be added to
 $unusedoptions in schema.php.

 Separately: @josephscott previously attempted to remove my-hacks.php.
 There are almost no CPU cycles gained by removing it, as hack_file is an
 autoloaded option. It's nice to clean it up, of course, but I'll reveal
 that he scanned all VaultPress sites for the existence of my-hacks.php and
 found 6 that still used it. That's a very low number, except that two of
 them were the sites of WordPress co-founders. So we ended up just dropping
 it.

 I doubt that this will break a site, and I don't care enough to revert
 this, but we should do a make/core post about it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33741#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform