[wp-trac] [WordPress Trac] #28290: Changing _site_option functions for _network_option functions

[WordPress Trac]

#28290: Changing _site_option functions for _network_option functions
------------------------------------+---------------------------
 Reporter:  jmlapam                 |       Owner:  spacedmonkey
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.4
Component:  Networks and Sites      |     Version:  4.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  multisite
------------------------------------+---------------------------
Changes (by DrewAPicture):

 * keywords:  needs-patch => has-patch dev-feedback


Comment:

 @spacedmonkey: Really nice work on a first pass. Some notes:

 * It would be good to patch the function changes separately from the
 changeovers from `*_site_option` to `*_network_option`, especially since
 they'll probably be committed separately anyway. Also, easier to grok
 changes  during iteration
 * I'm not 100 percent on board with introducing new hooks in the name of
 vernacular, that is to say, new hooks that do exactly the same thing but
 are named differently. This is one area of core where we're starting to
 see a lot of technical debt (duplicate hooks with different names)
 * We should add changelog entries to the DocBlocks for the `*_site_option`
 functions indicating that they were converted to wrappers for
 `*_network_option`
 * Looks like there's copy pasta in the hook doc `@since` for
 `pre_delete_network_option_' . $option`
 * Always use spaces in phpDocs, never tabs :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28290#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform