[wp-trac] [WordPress Trac] #32802: Update Masonry (v3.3.0) & imagesLoaded (v3.1.8) package

[WordPress Trac]

#32802: Update Masonry (v3.3.0) & imagesLoaded (v3.1.8) package
-------------------------------------------------+-------------------------
 Reporter:  Ninos Ego                            |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  External Libraries                   |  Review
 Severity:  normal                               |     Version:  4.3
 Keywords:  needs-testing needs-codex dev-       |  Resolution:
  feedback has-patch                             |     Focuses:  javascript
-------------------------------------------------+-------------------------
Changes (by Ninos Ego):

 * keywords:  needs-testing needs-codex dev-feedback needs-patch => needs-
     testing needs-codex dev-feedback has-patch


Comment:

 I would definitely remove 'jquery-masonry'. The version is very old. I
 don't think that so many themes use 'masonry', even less 'jquery-masonry'.
 By removing 'jquery-masonry' you'll not break much themes. Also sometime
 you need to force them to update their theme, you cannot stay
 backwardcompatible for ever.

 Regarding the dependency of imagesLoaded, I would not add that. There are
 also people which want to use masonry without the imagesLoaded library
 (e.g. myself). Here again I'm sure you'll not break much themes, and if,
 they should update their theme (therefor you have major updates :D).

 Attached my updated patch (with newest version of the masonry library).

 PS: In one of my current themes I'm using masonry on many places and had
 no problems with that patch. Also the masonry feature of the famous page
 builder plugin 'VisualComposer' had no problems.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32802#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform