[wp-trac] [WordPress Trac] #16894: Bulk load Comment Meta upon access
WordPress Trac
noreply at wordpress.org
Thu Sep 17 19:54:21 UTC 2015
#16894: Bulk load Comment Meta upon access
-----------------------------------+---------------------------
Reporter: dd32 | Owner: boonebgorges
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Comments | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion | Focuses: performance
-----------------------------------+---------------------------
Comment (by boonebgorges):
[34268] turns on commentmeta priming by default. For the purposes of
viewing comments on a single page, via `comments_template()` - which is
the most common use of comments, and is the most likely to cause
performance concerns - I'm going to introduce lazy-loading.
A note that I'm not going to set a `$wp_query` flag. `update_meta_cache()`
should be idempotent for the same set of comment IDs; the function bails
early if all objects have already had their metadata loaded into cache. If
we find that calling `update_meta_cache()` more times than strictly
necessary is causing real-life performance issues, let's introduce a
`comment_meta_updated` flag or something like that.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16894#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list