[wp-trac] [WordPress Trac] #33128: admin_menu not called when attachment form is loaded in a frame

WordPress Trac noreply at wordpress.org
Thu Sep 17 05:36:33 UTC 2015


#33128: admin_menu not called when attachment form is loaded in a frame
--------------------------+---------------------------------
 Reporter:  cvedovini     |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Media         |     Version:  3.5
 Severity:  normal        |  Resolution:  wontfix
 Keywords:                |     Focuses:  ui, administration
--------------------------+---------------------------------

Comment (by cvedovini):

 Replying to [comment:3 wonderboymusic]:
 > Like @SergeyBiryukov said, `'admin_menu'` is only intended to run when
 the Admin Menu is being created, that's it. I'm sorry if that's where you
 were hooking previously, but it not firing when the modal / frame loads is
 not a breaking change. Unrelated contexts.

 In that case why is it firing the first time the frame is loaded (there's
 no menu in the frame) but not in the subsequent JS calls.

 I will add that I used admin_menu to hook because this is what is
 documented everywhere you can find an example about adding custom fields
 to the media upload page. It was working, it's not working anymore, that's
 a breaking change whatever the reason for it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33128#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list