[wp-trac] [WordPress Trac] #32093: Inconsistent class names between get_image_tag() and wp_get_image_attachment()

WordPress Trac noreply at wordpress.org
Thu Sep 17 01:06:49 UTC 2015


#32093: Inconsistent class names between get_image_tag() and
wp_get_image_attachment()
--------------------------+------------------
 Reporter:  tychay        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.4
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------

Comment (by joemcgill):

 I would prefer adding `size-{size}`, as the OP suggests, to
 `wp_get_attachment_image()` rather than adding `attachment-{size}` to
 `get_post_image()` unless there's a reason not to. Seems likely that there
 would potentially be less collisions with other things using
 `.attachment-{foo}` class selectors in their CSS.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32093#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list