[wp-trac] [WordPress Trac] #33837: We should avoid Superglobals when possible

[WordPress Trac]

#33837: We should avoid Superglobals when possible
-----------------------------------+-----------------------------
 Reporter:  wonderboymusic         |       Owner:  wonderboymusic
     Type:  enhancement            |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.4
Component:  General                |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:
-----------------------------------+-----------------------------
Changes (by kitchin):

 * keywords:  needs-patch 2nd-opinion => 2nd-opinion has-patch


Comment:

 By the way, the committed name, `wp_validate_action` was mentioned in
 "Week in Core: Aug. 31 - Sept. 12, 2015." Somebody wrap this thing up!
 Despite -1 in `<select>`, the commit is not quite right in my opinion
 because it depends on user agents doing things right. Patch
 33837.stringish.diff is ready to go if you want it and still applied to
 trunk last time I tried with svn.

 Then we can open part 2. Look how much fun we'll have with these:
 {{{
 wp-admin/edit.php (1 hit)
         $done = bulk_edit_posts($_REQUEST);
 wp-admin/includes/ajax-actions.php (1 hit)
         _wp_ajax_menu_quick_search( $_POST );
 wp-admin/includes/bookmark.php (2 hits)
         return wp_update_link( $_POST );
         return wp_insert_link( $_POST );
 wp-admin/includes/class-wp-media-list-table.php (1 hit)
         list( $post_mime_types, $avail_post_mime_types ) =
 wp_edit_attachments_query( $_REQUEST );
 wp-admin/includes/post.php (1 hit)
         $post_ID = wp_insert_post( $_POST );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33837#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform