[wp-trac] [WordPress Trac] #33587: Notification Functions Should be Replaced by Hooks

WordPress Trac noreply at wordpress.org
Wed Sep 16 22:20:29 UTC 2015


#33587: Notification Functions Should be Replaced by Hooks
-----------------------------------+---------------------------
 Reporter:  dshanske               |       Owner:  boonebgorges
     Type:  enhancement            |      Status:  reopened
 Priority:  normal                 |   Milestone:  4.4
Component:  Mail                   |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:33 SergeyBiryukov]:
 > Is there a reason why `wp_new_comment_notify_moderator()` uses the
 passed `$comment_approved` argument, while
 `wp_new_comment_notify_postauthor()` uses `get_comment()` to get the same
 value? Shouldn't they both use the same method for consistency?

 Only as a relic of the way the patch was originally written :-/ I'll
 change it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33587#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list