[wp-trac] [WordPress Trac] #33793: Adding a user with a username 52 characters or longer fails, but displays success message.

[WordPress Trac]

#33793: Adding a user with a username 52 characters or longer fails, but displays
success message.
----------------------------------------+-----------------------------
 Reporter:  tommarshall                 |       Owner:  boonebgorges
     Type:  defect (bug)                |      Status:  closed
 Priority:  normal                      |   Milestone:  4.4
Component:  Users                       |     Version:  3.8.8
 Severity:  normal                      |  Resolution:  fixed
 Keywords:  needs-unit-tests has-patch  |     Focuses:  administration
----------------------------------------+-----------------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"34218"]:
 {{{
 #!CommitTicketReference repository="" revision="34218"
 Improve validation of `user_login` and `user_nicename` length.

 The `user_login` field only allows 60 characters, and `user_nicename`
 allows
 50. However, there are no protections in the interface, and few in the
 code,
 that prevent the creation of users with values in excess of these limits.
 Prior
 to recent changes in `$wpdb`, users were generally created anyway, MySQL
 having performed the necessary truncation. More recently, the `INSERT`s
 and
 `UPDATE`s simply fail, with no real feedback on the nature of the failure.

 This changeset addresses the issue in a number of ways:
 * On the user-new.php and network/user-new.php panels, don't allow input
 in excess of the maximum field length.
 * In `wp_insert_user()`, throw an error if the value provided for
 `'user_login'` or `'user_nicename'` exceeds the maximum field length.
 * In `wp_insert_user()`, when using `'user_login'` to generate a default
 value for `'user_nicename'`, ensure that the nicename is properly
 truncated, even when suffixed for uniqueness (username-2, etc).

 Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
 Fixes #33793.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33793#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform