[wp-trac] [WordPress Trac] #33735: Reduce Duplication and Improve Comment Notification Email Functions

[WordPress Trac]

#33735: Reduce Duplication and Improve Comment Notification Email Functions
--------------------------------------+------------------------------
 Reporter:  dshanske                  |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  low                       |   Milestone:  Awaiting Review
Component:  Mail                      |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------------

Comment (by dshanske):

 Applied the suggested changes. I originally didn't sprintify the comment
 line as it provides the same link to the entire comment section
 regardless, but it would be consistent with the old behavior.

 But re $comment vs $comment_id, that was intentionally. I'm proposing
 switching to using get_comment_text, get_comment_author_link, etc. All of
 which have filters on them, as opposed to accessing the comment data
 directly. This opens the door to a variety of enhancements that plugins
 may already have enabled for this code. They all take $comment_id as a
 parameter.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33735#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform