[wp-trac] [WordPress Trac] #21949: Allow private taxonomies (public = false)

[WordPress Trac]

#21949: Allow private taxonomies (public = false)
--------------------------------+------------------
 Reporter:  wpsmith             |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  4.4
Component:  Taxonomy            |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch rest-api  |     Focuses:
--------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch needs-unit-tests rest-api 4.4-early => has-patch
     rest-api
 * milestone:  Future Release => 4.4


Comment:

 [attachment:21949.2.diff] adds a couple simple unit test.

 I also simplified the logic quite a bit. Unless I'm totally missing
 something, `parse_request()` does not, and never did, accept an array of
 values for the 'taxonomy' parameter. Thus `example.com?taxonomy=foo,bar`
 and `example.com?taxonomy[]=foo&taxonomy[]=bar` are both invalid, and we
 don't need to handle these cases.

 Also, I'm not sure I understand why nacin suggested an `is_admin()`
 exception. We don't appear to make a similar exception anywhere else when
 parsing the request, and I'm not sure what the justification would be. (If
 we need exceptions, they should probably be based on caps.) In any case,
 `parse_request()` doesn't run during a normal admin pageload. Maybe I'm
 missing something obvious here?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21949#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform