[wp-trac] [WordPress Trac] #33417: JS error when uploading small image as Site Icon and electing to Skip Cropping

[WordPress Trac]

#33417: JS error when uploading small image as Site Icon and electing to Skip
Cropping
--------------------------+-------------------------
 Reporter:  truonght      |       Owner:  ocean90
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.3.1
Component:  Customize     |     Version:  4.3
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by obenland):

 Replying to [comment:10 tyxla]:
 > There is no reason to require the cropping IMHO - why not allow the
 image to remain untouched? There are many cases when the user has prepared
 a special image for the site icon, and they would want it to remain
 uncropped.

 There are two reasons to force cropping, being able to generate the
 correct image sizes for app icons and making sure the image is actually
 square.

 If [attachment:33417.diff] didn't fix your issue we should see what the
 problem is and fix it rather than just patching over an error.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33417#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform