[wp-trac] [WordPress Trac] #33837: We should avoid Superglobals when possible

[WordPress Trac]

#33837: We should avoid Superglobals when possible
----------------------------+-----------------------------
 Reporter:  wonderboymusic  |       Owner:  wonderboymusic
     Type:  enhancement     |      Status:  assigned
 Priority:  normal          |   Milestone:  4.4
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------------

Comment (by kitchin):

 I'm working on a follow-up patch. The original commit has one actual bug:
 {{{
 -               if ( isset( $_REQUEST['action'] ) && isset(
 $_REQUEST['delete_tags'] ) && ( 'delete' == $_REQUEST['action'] ||
 'delete' == $_REQUEST['action2'] ) )
 +               $action = wp_validate_action();
 +               if ( $action && isset( $_REQUEST['delete_tags'] ) && (
 'delete' == $action || 'delete' == $_REQUEST['action2'] ) )
 }}}
 The `isset( $_REQUEST['action'] )` is just there to detect the first bulk
 <select>. It can be empty, as long as the second <select> is truthy.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33837#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform