[wp-trac] [WordPress Trac] #33654: wp_new_user_notification breaking change.

[WordPress Trac]

#33654: wp_new_user_notification breaking change.
-------------------------------+------------------------------
 Reporter:  alexander.rohmann  |       Owner:  adamsilverstein
     Type:  defect (bug)       |      Status:  assigned
 Priority:  normal             |   Milestone:  4.3.1
Component:  Users              |     Version:  4.3
 Severity:  normal             |  Resolution:
 Keywords:  has-patch          |     Focuses:
-------------------------------+------------------------------

Comment (by adamsilverstein):

 Good to know that `@expectedDeprecated` takes care of that, I'll read up
 to learn more. Also, thanks for pointing out 5.2 requirement, wasn't sure
 that was required for unit tests.

 I did know my approach was convoluted, so thanks for cleaning that all up!

 Replying to [comment:18 ocean90]:
 > Replying to [comment:16 adamsilverstein]:
 > > In [attachment:33654.4.diff]:
 > > * Add an additional test verifying calling function with second
 argument thrown the deprecated error as expected
 >
 > `@expectedDeprecated` takes care of the deprecation notice,
 `$this->deprecated_called` isn't needed. Please have also in mind, that
 unit tests have to pass on PHP 5.2 too, so no closures in tests.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33654#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform